maggesandClaude Sonnet 5
8ac9cde621
Pods panel could previously only list pods - there was no way to create
one, start/stop/restart it, or attach a container to it from the UI.
Adds a "New Pod" modal (name + port mappings), a per-pod lifecycle menu
(start/stop/restart/remove), and an optional "Pod" field on the Create
Container modal to join an existing pod's network namespace. Backend
verified live against the real podman socket (/pods/create, /pods/{name}/
restart, container "pod" field).
Also fixes three real bugs found via live testing:
- Podman.page used Menu="Podman" instead of Menu="Tasks:<rank>", so the
plugin never actually appeared in Unraid's top navigation (traced through
PageBuilder.php/DefaultPageLayout.php/Navigation/Main.php - only pages
registered under "Tasks" become top-level tabs).
- app.js's shared context-menu component mis-mapped every item positioned
after a 'separator' entry to the wrong DOM element (an off-by-one against
menu.children, which includes the separator <div>s) - so "Remove", which
always sits after a separator, silently did nothing when clicked. Fixed
by indexing into querySelectorAll('button') instead.
- That same menu was positioned via "position: absolute" math that assumed
a viewport-relative containing block, but Unraid's own page wrapper
(webGui/styles/default-base.css's ".content") sets position:relative,
so the menu rendered far from its anchor button. Switched to
"position: fixed" with viewport-relative coordinates.
Incidentally, pods add a hidden "infra" container that was leaking into
the plain Containers list with no working lifecycle of its own (always
"running", so its own Remove was permanently disabled) - now filtered out
via libpod's IsInfra flag. And every action-buttons table cell used
"display: flex" directly on the <td>, which browsers can size
inconsistently row to row - moved onto an inner wrapper div instead, and
bumped .podman-btn-icon's touch target size.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
75 lines
2.5 KiB
JavaScript
75 lines
2.5 KiB
JavaScript
/**
|
|
* javascript/images.js
|
|
*
|
|
* Images panel: table + a "Pull Image" action, backed by ajax/images.php.
|
|
*/
|
|
(function () {
|
|
'use strict';
|
|
const P = window.Podman;
|
|
let images = [];
|
|
|
|
function rowHtml(img) {
|
|
const created = img.createdAt ? P.formatRelativeTime(img.createdAt) : '—';
|
|
return '' +
|
|
'<tr data-id="' + P.escapeHtml(img.id) + '">' +
|
|
'<td>' + P.escapeHtml(img.repository) + '</td>' +
|
|
'<td class="mono">' + P.escapeHtml(img.tag) + '</td>' +
|
|
'<td class="mono podman-row-sub">' + P.escapeHtml(img.shortId) + '</td>' +
|
|
'<td class="tnum">' + P.escapeHtml(img.sizeFormatted) + '</td>' +
|
|
'<td class="tnum">' + created + '</td>' +
|
|
'<td class="tnum">' + img.usedBy + '</td>' +
|
|
'<td class="podman-actions"><div class="podman-actions-row"><button class="podman-btn podman-btn-icon" data-action="remove"' +
|
|
(img.usedBy > 0 ? ' disabled title="In use by a container"' : ' title="Remove"') + '>🗑</button></div></td>' +
|
|
'</tr>';
|
|
}
|
|
|
|
function render() {
|
|
const tbody = P.el('images-tbody');
|
|
tbody.innerHTML = images.length
|
|
? images.map(rowHtml).join('')
|
|
: '<tr><td colspan="7" class="podman-empty-note">No images.</td></tr>';
|
|
}
|
|
|
|
function load() {
|
|
const tbody = P.el('images-tbody');
|
|
tbody.innerHTML = P.loadingRow(7);
|
|
return P.get('images', 'list').then(function (data) {
|
|
images = data;
|
|
render();
|
|
}).catch(function (err) {
|
|
tbody.innerHTML = P.errorRow(7, err.message);
|
|
});
|
|
}
|
|
|
|
function init() {
|
|
P.el('images-pull-btn').addEventListener('click', function () {
|
|
P.openFormModal({
|
|
title: 'Pull Image',
|
|
submitLabel: 'Pull',
|
|
fields: [
|
|
{ name: 'reference', label: 'Image reference', required: true, placeholder: 'docker.io/library/postgres:16' },
|
|
],
|
|
onSubmit: function (values) {
|
|
return P.post('images', 'pull', { reference: values.reference }).then(load);
|
|
},
|
|
});
|
|
});
|
|
|
|
P.el('images-tbody').addEventListener('click', function (e) {
|
|
const btn = e.target.closest('button[data-action="remove"]');
|
|
if (!btn || btn.disabled) return;
|
|
const id = btn.closest('tr').dataset.id;
|
|
if (!confirm('Remove this image?')) return;
|
|
btn.disabled = true;
|
|
P.post('images', 'remove', { id: id }).then(load).catch(function (err) {
|
|
alert('Remove failed: ' + err.message);
|
|
btn.disabled = false;
|
|
});
|
|
});
|
|
|
|
return load();
|
|
}
|
|
|
|
P.registerPanel('images', { init: init, refresh: load });
|
|
})();
|