maggesandClaude Sonnet 5
2e6832903b
- podman-common.sh: file-wide shellcheck disable=SC2034 for its constants, which are intentionally defined for other scripts to source, not used within the file itself (ShellCheck can't see cross-file usage in that direction). Confirmed as the actual cause of the failing ShellCheck job via the real Gitea Actions log. - podman-storage.sh: use the retry counter in cmd_unmount's log message instead of leaving it genuinely unused (real SC2034 hit, not a false positive). - lint.yml: replace the editorconfig-checker/action-* marketplace action with a pinned, checksum-verified direct binary download — more robust than relying on third-party action resolution on self-hosted Gitea Actions runners — and disable its IndentSize check, which false-positives on Markdown's nested-list indentation and shell heredoc bodies. scripts/dev/lint.sh mirrors the same check for local use. All three lint.yml jobs verified passing locally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
45 lines
1.6 KiB
Bash
Executable File
45 lines
1.6 KiB
Bash
Executable File
#!/bin/bash
|
|
# =============================================================================
|
|
# scripts/dev/lint.sh
|
|
#
|
|
# Local developer entry point mirroring .github/workflows/lint.yml: runs
|
|
# ShellCheck over shell scripts/SlackBuilds, xmllint over plugin/podman.plg,
|
|
# and editorconfig-checker over the whole repo. Requires `shellcheck`,
|
|
# `xmllint` (libxml2), and `ec` (editorconfig-checker) to be installed
|
|
# locally — see the "editorconfig" job in lint.yml for how CI installs it.
|
|
# =============================================================================
|
|
|
|
set -eu
|
|
|
|
REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
cd "$REPO_ROOT"
|
|
|
|
status=0
|
|
|
|
if command -v shellcheck > /dev/null 2>&1; then
|
|
echo "==> ShellCheck"
|
|
find plugin/rc.d plugin/sbin scripts -type f \
|
|
\( -name '*.sh' -o -name 'rc.*' -o -name '*.SlackBuild' \) \
|
|
-print0 \
|
|
| xargs -0 shellcheck --severity=warning --external-sources || status=1
|
|
else
|
|
echo "!! shellcheck not installed, skipping (install it to match CI: https://www.shellcheck.net/)" >&2
|
|
fi
|
|
|
|
if command -v xmllint > /dev/null 2>&1; then
|
|
echo "==> xmllint (plugin/podman.plg)"
|
|
xmllint --noout plugin/podman.plg || status=1
|
|
else
|
|
echo "!! xmllint not installed, skipping (part of libxml2-utils)" >&2
|
|
fi
|
|
|
|
if command -v ec > /dev/null 2>&1; then
|
|
echo "==> editorconfig-checker"
|
|
# -disable-indent-size: see the "editorconfig" job in lint.yml for why.
|
|
ec -disable-indent-size || status=1
|
|
else
|
|
echo "!! ec (editorconfig-checker) not installed, skipping (https://github.com/editorconfig-checker/editorconfig-checker)" >&2
|
|
fi
|
|
|
|
exit "$status"
|